RFR: 8276299: G1: Unify the wording buffer/node/element in G1SegmentedArrayXxx, G1CardSetXxx and related classes [v2]

Albert Mingkun Yang ayang at openjdk.java.net
Wed Dec 1 11:50:31 UTC 2021


On Wed, 1 Dec 2021 11:43:00 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Currently, the words "buffer", "node" and "element" are used together in G1SegmentedArrayXxx, G1CardSetXxx and related classes in an inconsistent way, which is very unfavorable for understanding.
>> 
>> We should not confuse buffer and node together, and not confuse node and element together. The new wording should be based on something like the following rule:
>> 
>> segmented array (1) -- segment (N) -- slot (M)
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Thomas review

Just a minor comment.

src/hotspot/share/gc/g1/g1SegmentedArray.hpp line 95:

> 93: // Counts and memory usage are current on a best-effort basis if accessed concurrently.
> 94: template<MEMFLAGS flag>
> 95: class G1SegmentedArrayFreeList {

The name should be `G1SegmentedArraySegmentList`, right?

-------------

Marked as reviewed by ayang (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6605



More information about the hotspot-gc-dev mailing list