RFR: 8278276: G1: Refine naming of G1GCParPhaseTimesTracker::_must_record
Stefan Johansson
sjohanss at openjdk.java.net
Mon Dec 6 10:20:13 UTC 2021
On Mon, 6 Dec 2021 03:13:05 GMT, Hamlin Li <mli at openjdk.org> wrote:
> This is a trivial improvement to refine the naming of G1GCParPhaseTimesTracker::_must_record to _initial_record.
I wonder if we could find an even better name than `initial_record`. The member is there to tell whether or not we can have multiple instances using the same phase. So something like `single_record` would be more accurate imho.
An alternative would be to switch the `bool` to be `false` by default and call it something like `allow_multiple_record`, not sure this is better. Let's here what other thinks.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6714
More information about the hotspot-gc-dev
mailing list