[jdk18] RFR: 8274007: [REDO] VM Exit does not abort concurrent mark [v2]
Thomas Schatzl
tschatzl at openjdk.java.net
Thu Dec 16 12:47:55 UTC 2021
On Thu, 16 Dec 2021 09:03:39 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:
>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>>
>> sjohanss review
>
> src/hotspot/share/gc/g1/g1ConcurrentMark.cpp line 2022:
>
>> 2020:
>> 2021: // Clear all marks in the next bitmap for the next marking cycle. This will allow
>> 2022: // us to skip the next concurrent bitmap clearing.
>
> Pre-existing, but since you touch it. This comment could be brushed up even more to be more clear that this clearing is needed for the Full GC as well. I mean the only caller to `concurrent_cycle_abort()` is the Full GC so would not hurt. Not sure how old the comment is, but prior to the parallel Full GC we did not use the bitmap in the collection (but now we do).
I touched up these comments a bit. Thanks for noticing.
-------------
PR: https://git.openjdk.java.net/jdk18/pull/22
More information about the hotspot-gc-dev
mailing list