RFR: 8260012: Reduce inclusion of collectedHeap.hpp and heapInspection.hpp [v2]

[Ioi Lam]

On Tue, 2 Feb 2021 12:22:50 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - @tschatzl and @stefank comments
>>  - Merge branch 'master' into 8260012-reduce-inclue-collectedHeap-heapInspection-hpp
>>  - 8260012: Reduce inclusion of collectedHeap.hpp and heapInspection.hpp
>
> src/hotspot/share/gc/shared/memAllocator.hpp line 30:
> 
>> 28: #include "memory/memRegion.hpp"
>> 29: #include "oops/oopsHierarchy.hpp"
>> 30: #include "runtime/thread.hpp"
> 
> `utilities/globalDefinitions.hpp` for `HeapWord` is missing.

Fixed.

> src/hotspot/share/oops/compressedOops.inline.hpp line 28:
> 
>> 26: #define SHARE_OOPS_COMPRESSEDOOPS_INLINE_HPP
>> 27: 
>> 28: #include "gc/shared/collectedHeap.hpp"
> 
> `utilities/globalDefinitions.hpp` for `*PTR_FORMAT` and others is missing.

Fixed.

> src/hotspot/share/oops/oop.inline.hpp line 28:
> 
>> 26: #define SHARE_OOPS_OOP_INLINE_HPP
>> 27: 
>> 28: #include "gc/shared/collectedHeap.hpp"
> 
> `utilities/globalDefinitions.hpp` for `HeapWord` is missing.
> `globals.hpp` for some globals.
> `oopsHierarchy.hpp` for `narrowKlass`
> `utilties/debug.hpp` for `assert`

Fixed. Thanks for the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2347