Integrated: 8234534: Simplify CardTable code after CMS removal
Thomas Schatzl
tschatzl at openjdk.java.net
Fri Feb 5 08:36:41 UTC 2021
On Tue, 2 Feb 2021 15:13:38 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi,
>
> can I have reviews for this cleanup that removes CMS specific code from `CardTable/CardTableRS`?
>
> Note that there is still this "conc_scan" parameter passed to the card table that affects barrier code generation, for some reason also G1 barrier code generation although it should not as `G1CardTable::scanned_concurrently()` only used for the "normal" card table. Initial attempts showed that removing this is not straightforward, causing crashes and so I left it out for [JDK-8250941](https://bugs.openjdk.java.net/browse/JDK-8260941) so that this change is solely about removing unused code.
>
> Testing: tier1-4, some tier1-5 runs earlier (before some removal of hunks for files only containing copyright updates or newline changes)
This pull request has now been integrated.
Changeset: 78b0d327
Author: Thomas Schatzl <tschatzl at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/78b0d327
Stats: 205 lines in 9 files changed: 0 ins; 191 del; 14 mod
8234534: Simplify CardTable code after CMS removal
Reviewed-by: ayang, kbarrett
-------------
PR: https://git.openjdk.java.net/jdk/pull/2354
More information about the hotspot-gc-dev
mailing list