RFR: 8261356: Clean up enum G1Mark [v2]

Albert Mingkun Yang ayang at openjdk.java.net
Tue Feb 9 12:45:52 UTC 2021


On Tue, 9 Feb 2021 10:18:17 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/gc/g1/g1RootClosures.cpp line 53:
> 
>> 51: // The treatment of "weak" roots is selectable through the template parameter,
>> 52: // this is usually used to control unloading of classes and interned strings.
>> 53: template <bool mark_weak>
> 
> I think it could make sense to name this parameter `should_mark_weak` to be more consistent. But if you don't agree just leave it.

Fixed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2461



More information about the hotspot-gc-dev mailing list