RFR: 8261230: GC tracing of page sizes are wrong in a few places [v2]

Albert Mingkun Yang ayang at openjdk.java.net
Fri Feb 12 12:27:45 UTC 2021


On Thu, 11 Feb 2021 18:10:57 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> The usage of `os::trace_page_sizes()` and friends are wrongly assuming that we always get the page size requested and needs to be updated. This is done by using the helper `ReservedSpace::actual_reserved_page_size()` instead of blindly trusting we get what we ask for. I have plans for the future to get rid of this helper and instead record the page size used in the `ReservedSpace`, but for now the helper is good enough. 
>> 
>> In G1 we used the helper but switched the order of the page size and the alignment parameter, which in turn helped the test to pass since the alignment will match the page size we expect in the test. The test had to be improved to recognize mapping failures.
>
> Stefan Johansson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Albert review
>   
>   Renamed helper to improve how the code read. Also extracted the failure check into a separate function.

Marked as reviewed by ayang (Author).

-------------

PR: https://git.openjdk.java.net/jdk/pull/2486



More information about the hotspot-gc-dev mailing list