RFR: 8242032: G1 region remembered sets may contain non-coarse level PRTs for already coarsened regions [v2]
Joakim Nordström
github.com+779991+jaokim at openjdk.java.net
Fri Feb 19 11:26:19 UTC 2021
On Fri, 19 Feb 2021 10:38:35 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Joakim Nordström has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Clarified comment on re-checking coarsening
>> - Minor typo
>
> src/hotspot/share/gc/g1/heapRegionRemSet.cpp line 149:
>
>> 147: MutexLocker x(_m, Mutex::_no_safepoint_check_flag);
>> 148:
>> 149: // Make sure region hasn't been coarsened by other thread.
>
> Maybe mentioning this is an intentional re-check under lock, sth like, "Rechecking if the region is coarsened while holding the lock."
Yes, thank you!
-------------
PR: https://git.openjdk.java.net/jdk/pull/2545
More information about the hotspot-gc-dev
mailing list