RFR: JDK-8256155: os::Linux Populate all large_page_sizes, select smallest page size in reserve_memory_special_huge_tlbfs* [v16]
Stefan Johansson
sjohanss at openjdk.java.net
Wed Feb 24 08:40:45 UTC 2021
On Wed, 24 Feb 2021 08:14:48 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Marcus G K Williams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 25 commits:
>>
>> - Merge branch 'master' into pull/1153
>> - kstefanj update
>>
>> Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>
>> - Merge branch 'master' into update_hlp
>> - Merge branch 'master' into update_hlp
>> - Remove extraneous ' from warning
>>
>> Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>
>> - Merge branch 'master' into update_hlp
>> - Merge branch 'master' into update_hlp
>> - Merge branch 'master' into update_hlp
>> - Fix os::large_page_size() in last update
>>
>> Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>
>> - Ivan W. Requested Changes
>>
>> Removed os::Linux::select_large_page_size and
>> use os::page_size_for_region instead
>>
>> Removed Linux::find_large_page_size and use
>> register_large_page_sizes. Streamlined
>> Linux::setup_large_page_size
>>
>> Signed-off-by: Marcus G K Williams <marcus.williams at intel.com>
>> - ... and 15 more: https://git.openjdk.java.net/jdk/compare/f4cfd758...f2e44ac7
>
> src/hotspot/os/linux/os_linux.cpp line 3692:
>
>> 3690: ls.print("Available page sizes: ");
>> 3691: _page_sizes.print_on(&ls);
>> 3692: }
>
> Does this work and show something? I know UL is initialization time sensitive (which is annoying btw).
This comes from I comment I made and UL is initialized here. Not sure this is exactly where this should end up since it will only be printed when large pages are enabled. I think it might make sense to move somewhere else or make it a completely separate change.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1153
More information about the hotspot-gc-dev
mailing list