RFR: 8261804: Remove field _processing_is_mt, calculate it instead
Leo Korinth
lkorinth at openjdk.java.net
Thu Feb 25 13:09:40 UTC 2021
On Wed, 24 Feb 2021 17:58:29 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> In the reference processor, remove _processing_is_mt. Instead calculate its value in its accessor, processing_is_mt().
>>
>> This change will remove some state, make RefProcMTDegreeAdjuster a bit simpler and make it much easier to derive when processing is indeed multi threaded.
>
> src/hotspot/share/gc/shared/referenceProcessor.hpp line 417:
>
>> 415:
>> 416: // Whether we are in a phase when _processing_ is MT.
>> 417: bool processing_is_mt() const { return ParallelRefProcEnabled && _num_queues > 1; }
>
> I don't think this needs to be inline, and I think moving it to the .cpp file would avoid needing to include gc_globals.hpp here.
I agree and will fix it, thanks for spotting it!
-------------
PR: https://git.openjdk.java.net/jdk/pull/2704
More information about the hotspot-gc-dev
mailing list