RFR: 8258382: Fix optimization-unstable code involving pointer overflow [v2]

Ningsheng Jian njian at openjdk.java.net
Mon Jan 4 05:37:56 UTC 2021


On Mon, 4 Jan 2021 04:02:28 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> This change should not have been pushed with only one review. HotSpot changes normally require two reviews.
> https://wiki.openjdk.java.net/display/HotSpot/Pushing+a+HotSpot+change
> 
> I know the skara bots said it was ready to go. They haven't yet been taught about such project-specific tailorings of the base process. (The information in that page has supposedly been superseded by the new Developers' Guide (https://openjdk.java.net/guide/index.html), but the HotSpot reviewer requirements seem to have not made the transition. I'll bring that up with the dev-guide folks.)

Thanks for the reminder! Sorry, I (mistakenly) thought that this is trivial change. I've also reviewed the patch internally and should  have marked it reviewed by me before sponsoring.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1886



More information about the hotspot-gc-dev mailing list