RFR: 8258534: Epsilon: clean up unused includes
Aleksey Shipilev
shade at openjdk.java.net
Mon Jan 4 09:43:55 UTC 2021
On Fri, 11 Dec 2020 05:03:56 GMT, Lehua Ding <github.com+13173904+lhtin at openjdk.org> wrote:
> Hi all,
>
> CLion IDE shows two warnings of unused includes(`#include "utilities/macros.hpp"`) in EpsilonGC's code. these maybe can be removed.
>
> Testing: macosx-x86_64-server-{release,fastdebug,slowdebug}
On the second look, the `#include` for `macro.hpp` is indeed excessive: `COMPILER1` and `COMPILER2` are already defined, so the rest of the `#include`-s should work fine. The only reason we would want that include if Epsilon used any of the extended definitions like `COMPILER2_ONLY`, but it does not.
The patch looks good then. Please make sure you run the pre-integration tests. To do that, GH Actions should be enabled here: https://github.com/lhtin/jdk/actions -- and then probably triggered manually on your branch. Then "Checks" tab should have the test results. Once that is done, I would formally approve.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1745
More information about the hotspot-gc-dev
mailing list