RFR: 8258490: Shenandoah: Full GC does not need to remark threads and drain SATB buffers [v2]

Aleksey Shipilev shade at openjdk.java.net
Mon Jan 4 12:02:57 UTC 2021


On Wed, 16 Dec 2020 19:04:09 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

>> Full GC marks heap at a pause with SATB deactivated, therefore, we don't need to remark threads and drain SATB buffers during final mark phase.
>> 
>> - [x] hotspot_gc_shenandoah
>
> Zhengyu Gu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor update

Looks fine to me, modulo minor nit.

src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp line 230:

> 228: class ShenandoahClaimThreadClosure : public ThreadClosure {
> 229: private:
> 230:   uintx _claim_token;

Should be `const`, maybe?

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/1805



More information about the hotspot-gc-dev mailing list