[jdk16] RFR: 8258985: Parallel WeakProcessor may use too few threads [v2]
Kim Barrett
kbarrett at openjdk.java.net
Fri Jan 8 12:48:15 UTC 2021
On Fri, 8 Jan 2021 11:26:11 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fix doc comments about number of threads used
>
> Lgtm although the comments in the documentation for both `static void weak_oops_do` method declarations mentions:
>
> // Parallel version. Uses ergo_workers(), active workers, and
> // phase_time's max_threads to determine the number of threads to use.
> which should be fixed.
>
> One option is to put something like "Uses max workers and the total number of weak references to determine the number of threads to use" as description for `ergo_workers` and remove the details in the description of the `weak_oops_do` descriptions, but just removing the mention of `active_workers` there could be fine too.
Thanks @tschatzl . I've updated the descriptions of the weak_oops_do functions, and also added a description for ergo_workers.
-------------
PR: https://git.openjdk.java.net/jdk16/pull/75
More information about the hotspot-gc-dev
mailing list