[jdk16] RFR: 8258985: Parallel WeakProcessor may use too few threads [v2]
Albert Mingkun Yang
ayang at openjdk.java.net
Fri Jan 8 14:05:06 UTC 2021
On Fri, 8 Jan 2021 12:57:42 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Thanks @tschatzl . I've updated the descriptions of the weak_oops_do functions, and also added a description for ergo_workers.
>
> What's the argument for using `total_workers()` here? BTW, `G1ConcurrentMark::weak_refs_work` is in the caller chain. According to its name, it happens outside a pause.
> weak_refs_work is called in the remark pause.
Indeed, I should have followed the call chain one more step. Then, `WeakProcessor::weak_oops_do` is always called in a pause, right? Maybe this is worth mentioning in the comment.
-------------
PR: https://git.openjdk.java.net/jdk16/pull/75
More information about the hotspot-gc-dev
mailing list