[jdk16] RFR: 8259380: Correct pretouch chunk size to cap with actual page size [v3]
Patrick Zhang
qpzhang at openjdk.java.net
Mon Jan 11 15:44:18 UTC 2021
On Mon, 11 Jan 2021 15:22:20 GMT, Patrick Zhang <qpzhang at openjdk.org> wrote:
>> src/hotspot/share/gc/shared/pretouchTask.cpp line 70:
>>
>>> 68: // large pages size if UseLargePages was set, otherwise processing chunks with
>>> 69: // much smaller size inside large size pages would hurt performance.
>>> 70: // Revising page_size should be placed after having decided the proper chuck_size.
>>
>> Something like
>>
>> `// Chunk size should be at least (unmodified) page size as using multiple threads pretouch on a single chunk can decrease performance.`
>>
>> is sufficient here.
>
> Sure I will update this accordingly, thanks
Done
-------------
PR: https://git.openjdk.java.net/jdk16/pull/97
More information about the hotspot-gc-dev
mailing list