[jdk16] RFR: 8258985: Parallel WeakProcessor may use too few threads [v2]

Stefan Johansson sjohanss at openjdk.java.net
Tue Jan 12 15:16:04 UTC 2021


On Fri, 8 Jan 2021 12:48:14 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Please review this fix to the parallel WeakProcessor's computation of the
>> number of worker threads to use.  It was previously limited by the current
>> value of active_workers(), whatever that happens to be.  It should be
>> limited by total_workers(), just as with the parallel ReferenceProcessor.
>> (Both are subject to ReferencesPerThread.)
>> 
>> Testing
>> mach5 tier1
>> Some hand testing (Linux-x64) to verify the expected number of threads are
>> being used.
>> 
>> Note: That hand testing suggests some further tuning of ReferencesPerThread
>> might be in order. With the current default of 1000, I often saw in testing
>> that some threads were started late enough that no work was left for them.
>> I'll file a separate RFE for that.
>
> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix doc comments about number of threads used

Marked as reviewed by sjohanss (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk16/pull/75



More information about the hotspot-gc-dev mailing list