RFR: 8074101: Add verification that all tasks are actually claimed during roots processing [v3]

Kim Barrett kbarrett at openjdk.java.net
Wed Jan 13 09:21:57 UTC 2021


On Wed, 13 Jan 2021 09:09:25 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> src/hotspot/share/gc/shared/workgroup.hpp line 29:
>> 
>>> 27: 
>>> 28: #include "memory/allocation.hpp"
>>> 29: #include "metaprogramming/logical.hpp"
>> 
>> Should also add metaprogramming/enableIf.hpp, to avoid implicit include dependency.
>
> Should I include both `enableIf.hpp` and `logical.hpp`, or only `enableIf.hpp` since it includes `logical.hpp` already?

We don't have any tooling support, but there has been a trend away from relying on implicit includes, because they lead to breakages far away from refactorings that change includes.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2046



More information about the hotspot-gc-dev mailing list