RFR: 8255019: Shenandoah: Split STW and concurrent mark into separate classes [v27]

Aleksey Shipilev shade at openjdk.java.net
Wed Jan 13 15:06:11 UTC 2021


On Mon, 11 Jan 2021 17:38:41 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Zhengyu Gu has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 34 commits:
>> 
>>  - Merge branch 'master' into JDK-8255019-sh-mark
>>  - Silent MacOSX build
>>  - @shade's comments
>>  - Merge
>>  - Update copyright years
>>  - Merge
>>  - Merge branch 'master' into JDK-8255019-sh-mark
>>  - Concurrent mark does not expect forwarded objects
>>  - Merge branch 'master' into JDK-8255019-sh-mark
>>  - Merge branch 'master' into JDK-8255019-sh-mark
>>  - ... and 24 more: https://git.openjdk.java.net/jdk/compare/4d3d5991...a6540b99
>
> src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 2212:
> 
>> 2210:       if (point == _degenerated_mark) {
>> 2211:         finish_mark();
>> 2212:       }
> 
> So if we don't call `finish_mark`, do we ever call  `set_concurrent_mark_in_progress(false);` and `mark_complete_marking_context();`?

This was not answered, and I don't see relevant follow-up changes. Is this a bug?

-------------

PR: https://git.openjdk.java.net/jdk/pull/1009



More information about the hotspot-gc-dev mailing list