RFR: 8074101: Add verification that all tasks are actually claimed during roots processing [v5]

Albert Mingkun Yang ayang at openjdk.java.net
Fri Jan 15 19:32:06 UTC 2021


On Fri, 15 Jan 2021 14:37:45 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/gc/shared/workgroup.cpp line 377:
> 
>> 375:   // all non-skipped tasks are claimed
>> 376:   for (uint i = 0; i < _n_tasks; ++i) {
>> 377:     if (_tasks[i] == 0) {
> 
> pre-existing: This could be fixed in a separate CR: _tasks could be an array of bool instead of (u)int. Using an int is a historic artifact of not having a good Atomics library.

Created a ticket (JDK-8259851) for it; will start working on that after this is merged. Thanks for the suggestion.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2046



More information about the hotspot-gc-dev mailing list