Integrated: 8259870: zBarrier.inline.hpp should not include javaClasses.hpp

Ioi Lam iklam at openjdk.java.net
Tue Jan 19 06:47:53 UTC 2021


On Sun, 17 Jan 2021 23:53:53 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> zBarrier.inline.hpp is a popular header file (it's included by about 430 out of ~1000 hotspot .o files). It includes javaClasses.hpp only for the inline function verify_on_weak(), which is used only for assert purposes in debug builds.
> 
> javaClasses.hpp is large and in turn pulls in other large header files. If we move verify_on_weak() into zBarrier.cpp and stop including javaClasses.hpp in zBarrier.inline.hpp, building hotspot is about 0.5% faster. The number of .o files that include javaClasses.hpp is reduced from 459 to 175.
> 
> Testing: 
> Tested with mach5: tier1, builds-tier2, builds-tier3, builds-tier4 and builds-tier5. Also locally: aarch64, arm, ppc64, s390, x86, and zero.

This pull request has now been integrated.

Changeset: 14ce8f1a
Author:    Ioi Lam <iklam at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/14ce8f1a
Stats:     33 lines in 3 files changed: 17 ins; 13 del; 3 mod

8259870: zBarrier.inline.hpp should not include javaClasses.hpp

Reviewed-by: stefank, tschatzl

-------------

PR: https://git.openjdk.java.net/jdk/pull/2120



More information about the hotspot-gc-dev mailing list