RFR: 8258383: vmTestbase/gc/g1/unloading/tests/unloading_compilation_level[1, 2, 3] time out without TieredCompilation [v2]

[Vladimir Kozlov]

On Tue, 19 Jan 2021 18:08:57 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Tobias Hartmann has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed TieredCompilation flag from compilation level 4 tests
>
> Good.

> Thanks for the review Vladimir.
> 
> > I see such requires patter in other tests too.
> > But what will happen if server VM is built without C1 - no tiered?
> > Such tests may need additions requires vm.compiler1.enabled
> 
> Yes, I've took that pattern from other tests. The problem with `requires vm.compiler1.enabled` is that the test will be skipped if `-XX:-TieredCompilation` is set (because then C1 is not available). Since this is a general problem that affects other tests as well, I think it should be addressed separately if necessary. What do you think?

Yes, you are right about switching off C1 with TieredCompilation flag. Current changes are fine.
I agree with addressing C1 absence from VM build in separate changes. I think we need additional `requires` feature to check if C1/C2 are included in VM build. `vm.server` is not enough.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2125