Integrated: 8260048: Shenandoah: ShenandoahMarkingContext asserts are unnecessary

Aleksey Shipilev shade at openjdk.java.net
Thu Jan 21 07:24:56 UTC 2021


On Wed, 20 Jan 2021 13:20:41 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> There are two `shenandoah_assert_not_forwarded` asserts that are not necessary in `mark_{strong,weak}`, because the only caller [already asserts](https://github.com/openjdk/jdk/blob/master/src/hotspot/share/gc/shenandoah/shenandoahMark.inline.hpp#L272) this higher-level invariant. There is no need to check it in `ShenandoahMarkingContext` once again. This simplifies the fastpath in fastdebug builds.
> 
> Additional testing:
>  - [x] `hotspot_gc_shenandoah`
>  - [x] `tier1`, `tier2` with Shenandoah

This pull request has now been integrated.

Changeset: 5940287b
Author:    Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/5940287b
Stats:     4 lines in 1 file changed: 0 ins; 2 del; 2 mod

8260048: Shenandoah: ShenandoahMarkingContext asserts are unnecessary

Reviewed-by: zgu, rkennke

-------------

PR: https://git.openjdk.java.net/jdk/pull/2164



More information about the hotspot-gc-dev mailing list