RFR: JDK-8260200: optimize FreeRegionList::remove_starting_at by removing u… [v2]

Hamlin Li mli at openjdk.java.net
Fri Jan 22 01:45:46 UTC 2021


On Thu, 21 Jan 2021 19:10:26 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8260200: optimize FreeRegionList::remove_starting_at by removing unnecessary reading and setting
>
> src/hotspot/share/gc/g1/heapRegionSet.cpp line 281:
> 
>> 279:   }
>> 280: 
>> 281:   if (prev == NULL) {
> 
> A brief doc on what `prev` and `next` point to could be nice; sth like: `prev` points to the node right before `first` or null when `first == _head`, etc.

Thanks Albert for pointing out these, I have changed as you suggested.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2181



More information about the hotspot-gc-dev mailing list