RFR: JDK-8260200: optimize FreeRegionList::remove_starting_at by removing u… [v2]

[Hamlin Li]

On Fri, 22 Jan 2021 08:54:16 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8260200: optimize FreeRegionList::remove_starting_at by removing unnecessary reading and setting
>
> src/hotspot/share/gc/g1/heapRegionSet.cpp line 252:
> 
>> 250:   } else {
>> 251:     assert_free_region_list(_tail != first, "invariant");
>> 252:   }
> 
> Since these checks no longer does anything other than assertions I think it would be nice to hide it in a helper that for production builds will do nothing using `NOT_DEBUG_RETURN`.

Thanks for revewing, just changed as you suggested.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2181