RFR: 8260106: Shenandoah: refactor reference updating closures and related code [v5]

Aleksey Shipilev shade at openjdk.java.net
Mon Jan 25 15:58:02 UTC 2021


On Mon, 25 Jan 2021 15:10:47 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
>> 
>>  - Renames
>>  - Eliminate UpdateRefsMode altogether
>>  - Simplify update_with_forwarded
>>  - Comment updates
>>  - Merge branch 'master' into JDK-8260106-shenandoah-simplify-updates
>>  - Simplify ShenandoahUpdateHeapRefsTask
>>  - Fix up generic update references too, introduce CONC_UPDATE
>>  - Simplify further after RESOLVE removal
>>  - Merge branch 'master' into JDK-8260106-shenandoah-simplify-updates
>>  - Rename maybe to atomic
>>  - ... and 2 more: https://git.openjdk.java.net/jdk/compare/ca20c63c...f2c1ecdb
>
> src/hotspot/share/gc/shenandoah/shenandoahOopClosures.hpp line 192:
> 
>> 190: class ShenandoahUpdateRefsSuperClosure : public BasicOopIterateClosure {
>> 191: protected:
>> 192:   ShenandoahHeap* _heap;
> 
> While moving it around, maybe make it Shenandoah* const too?

Right! Did in new changeset.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2166



More information about the hotspot-gc-dev mailing list