RFR: 8260042: G1 Post-cleanup liveness printing occurs too early

Thomas Schatzl tschatzl at openjdk.java.net
Tue Jan 26 10:18:40 UTC 2021


On Fri, 22 Jan 2021 09:00:43 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I have reviews for this small change that fixes position of the Post-cleanup liveness printing, causing wrong gc efficiencies to be printed?
>> 
>> I.e. due to some older changes, the calculation of gc efficiences got moved below the printing of the Post-cleanup liveness which should be about these values. This change corrects that.
>> 
>> Note that there is a sister issue about not printing the gc efficiencies in the "Post-Marking" phase. This is not scope of this change.
>> 
>> Testing: manual testing that values are correct, hs-tier1+2
>
> Looks good!

Thanks @kstefanj @walulyai for your reviews.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2168



More information about the hotspot-gc-dev mailing list