RFR: JDK-8260200 G1: Remove unnecessary update in FreeRegionList::remove_starting_at [v4]

Hamlin Li mli at openjdk.java.net
Tue Jan 26 11:58:44 UTC 2021


On Tue, 26 Jan 2021 08:49:32 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8260200: G1: Remove unnecessary update in FreeRegionList::remove_starting_at
>
> src/hotspot/share/gc/g1/heapRegionSet.cpp line 234:
> 
>> 232:   assert_free_region_list(_head != next, "invariant");
>> 233:   if (next != NULL) {
>> 234:     assert_free_region_list(next->prev() != NULL, "invariant");
> 
> This assert could be next->prev() == curr, or am I missing some case?

Thanks for pointing out, changed as you suggested.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2181



More information about the hotspot-gc-dev mailing list