RFR: 8260497: Shenandoah: Improve SATB flushing

Aleksey Shipilev shade at openjdk.java.net
Wed Jan 27 15:47:55 UTC 2021


On Wed, 27 Jan 2021 10:50:21 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> src/hotspot/share/gc/shared/satbMarkQueue.hpp line 118:
>> 
>>> 116:   // Return true if the queue's buffer should be enqueued, even if not full.
>>> 117:   // The default method uses the buffer enqueue threshold.
>>> 118:   bool should_enqueue_buffer(SATBMarkQueue& queue);
>> 
>> Why drop `virtual` here? Is it because Shenandoah was the only virtual override of it, and now we can do the non-virtual call?
>
> Yes. IIRC we introduced that when we upstreamed Shenandoah, and can drop it again, thus restoring the original non-virtual version.

Okay then!

-------------

PR: https://git.openjdk.java.net/jdk/pull/2254



More information about the hotspot-gc-dev mailing list