RFR: 8217327: G1 Post-Cleanup region liveness printing should not print out-of-date efficiency [v2]
Joakim Nordström
github.com+779991+jaokim at openjdk.java.net
Thu Jan 28 08:44:56 UTC 2021
On Tue, 26 Jan 2021 09:14:20 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Joakim Nordström has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixed copyright year.
>
> src/hotspot/share/gc/g1/g1ConcurrentMark.cpp line 2981:
>
>> 2979:
>> 2980: // Print a line for this particular region.
>> 2981: if(gc_eff < 0) {
>
> I would prefer instead of the code duplication, use a `%s` format specifier for the efficiency, and a `FormatBuffer` to format the actual string into it. This should result in much shorter code.
Yes, I absolutely agree! Thanks!
-------------
PR: https://git.openjdk.java.net/jdk/pull/2217
More information about the hotspot-gc-dev
mailing list