RFR: 8260473: [vector] ZGC: VectorReshape test produces incorrect results with ZGC enabled [v4]

Vladimir Ivanov vlivanov at openjdk.java.net
Fri Jan 29 16:50:40 UTC 2021


On Fri, 29 Jan 2021 06:48:36 GMT, 王超 <github.com+25214855+casparcwang at openjdk.org> wrote:

> As far as I can see, during the parse phase, GraphKit contains the jvm state info which can be used to get the control and memory for creating new nodes. But during optimization, the jvm state info may be missing like the situation in PhaseVector::optimize_vector_boxes or Macro Expansion.

JVM state is irrelevant here (otherwise, `VectorUnbox` node would have captured relevant info during construction). What is actually missing is `GraphKit` instance lacks info about control and memory. You need to explicitly set it using `GraphKit::set_control()` and `GraphKit::set_all_memory()`.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2253



More information about the hotspot-gc-dev mailing list