Integrated: 8269821: Remove is-queue-active check in inner loop of write_ref_array_pre_work

Thomas Schatzl tschatzl at openjdk.java.net
Mon Jul 5 07:27:52 UTC 2021


On Fri, 2 Jul 2021 14:58:24 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

> Hi all,
> 
>   can I have reviews for this small micro-optimization that removes unnecessary work in the innermost loop of  write_ref_array_pre_work()?
> 
> In particular it removes the superfluous check whether marking is active (already done at the top of the loop) and hoists out several other code that the compiler for some reason does not automatically hoist.
> 
> Testing: tier1
> 
> Thanks,
>   Thomas

This pull request has now been integrated.

Changeset: 675a9520
Author:    Thomas Schatzl <tschatzl at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/675a9520b21e7adfded8a4bb8b1a06c1dcc6ccfb
Stats:     6 lines in 1 file changed: 4 ins; 0 del; 2 mod

8269821: Remove is-queue-active check in inner loop of write_ref_array_pre_work

Reviewed-by: ayang, kbarrett

-------------

PR: https://git.openjdk.java.net/jdk/pull/4669



More information about the hotspot-gc-dev mailing list