RFR: 8269914: Factor out heap printing for G1 young and full gc [v3]

Ivan Walulya iwalulya at openjdk.java.net
Thu Jul 8 13:50:52 UTC 2021

On Thu, 8 Jul 2021 12:21:33 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> can I have reviews for this change that factors out before/after heap related printing into a single scoped object to be used for both young and full gc code?
>> There is some minor change in order of printing of unrelated log output (COMMIT/UNCOMMIT region state changes vs. other heap printing), during full gc but since this is very low level debugging I do not see a problem to do that.
>> (Sorry for the trouble with open/closing this issue already: have been experimenting with the feature to base PRs on other PRs which kind-of failed a bit; rebased on tip after being able to push all dependencies, so this one should be good)
>> To keep JFR event sending in the correct order, this change includes JDK-8270018.
>> Thanks,
>>   Thomas
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>   ayang review


can we change

hpm -> heap_printer
jtm   -> tracer_mark

as done in G1FullGCScope


Marked as reviewed by iwalulya (Committer).

PR: https://git.openjdk.java.net/jdk/pull/4705

More information about the hotspot-gc-dev mailing list