RFR: 8270282: Semantically rename reference processing subphases
Albert Mingkun Yang
ayang at openjdk.java.net
Mon Jul 12 14:20:56 UTC 2021
On Mon, 12 Jul 2021 12:17:14 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Simple rename of phase{2,3,4} to something with semantic meaning.
>
> src/hotspot/share/gc/shared/referenceProcessorPhaseTimes.hpp line 83:
>
>> 81: ~ReferenceProcessorPhaseTimes();
>> 82:
>> 83: WorkerDataArray<double>* SoftWeakFinalRefsPhase_worker_time_sec() const { return _SoftWeakFinalRefsPhase_worker_time_sec; }
>
> This is a weird function name. I understand why, but I'm not convinced. We have process_soft_weak_final_refs and the like, for example.
How about `soft_weak_final_refs_phase_worker_time_sec()`?
-------------
PR: https://git.openjdk.java.net/jdk/pull/4752
More information about the hotspot-gc-dev
mailing list