RFR: 8261859: gc/g1/TestStringDeduplicationTableRehash.java failed with "RuntimeException: 'Rehash Count: 0' found in stdout" [v2]

Albert Mingkun Yang ayang at openjdk.java.net
Mon Mar 1 12:22:41 UTC 2021


On Mon, 1 Mar 2021 09:55:01 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> src/hotspot/share/gc/shared/stringdedup/stringDedupTable.cpp line 405:
>> 
>>> 403:       size = round_up_power_of_2(needed);
>>> 404:     } else {
>>> 405:       size = _max_size;
>> 
>> It's not obvious to me which one is larger, btw `round_up_power_of_2(needed)` and `_max_size`.
>
> This table implementation uses power of 2 sizes, including _min/max_size.
> That's assumed throughout.  Since needed < _max_size, rounding needed up to
> a power of 2 can't exceed _max_size.

I see; thanks for the explanation.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2769



More information about the hotspot-gc-dev mailing list