RFR: 8261859: gc/g1/TestStringDeduplicationTableRehash.java failed with "RuntimeException: 'Rehash Count: 0' found in stdout" [v2]
Albert Mingkun Yang
ayang at openjdk.java.net
Mon Mar 1 13:49:51 UTC 2021
On Mon, 1 Mar 2021 11:18:05 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
>>
>> limit shrink, add asserts for new size
>
> src/hotspot/share/gc/shared/stringdedup/stringDedupTable.cpp line 424:
>
>> 422: assert(size <= _max_size, "invariant: %zu", size);
>> 423: assert(size >= _min_size, "invariant: %zu", size);
>> 424: assert(is_power_of_2(size), "invariant: %zu", size);
>
> Please also use `SIZE_FORMAT` instead of `%zu` like in the overwhelming majority for formatting `size_t`.
I actually prefer `%zu`. I can't seem to find whether it's permitted or not in HotSpot Coding Style though.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2769
More information about the hotspot-gc-dev
mailing list