RFR: 8143041: Unify G1CollectorPolicy::PauseKind and G1YCType [v3]
Ivan Walulya
iwalulya at openjdk.java.net
Tue Mar 9 15:22:35 UTC 2021
On Tue, 9 Mar 2021 12:05:05 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Ivan Walulya has updated the pull request incrementally with one additional commit since the last revision:
>>
>> refactor after Thomas review
>
> Looks good otherwise.
Thanks @tschatzl , I have updated with the proposed changes
> src/hotspot/share/gc/g1/g1GCTypes.hpp line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2021, Oracle and/or its affiliates. All rights reserved.
>
> This should probably be `2012, 2021,` - I do not see a reason to remove the former date.
webrev shows this as a new file, while github shows it as a renamed file. Not sure which one to consider.
> src/hotspot/share/gc/g1/g1GCTypes.hpp line 53:
>
>> 51: public:
>> 52:
>> 53: static bool is_young_only_pause(G1GCType type) {
>
> `is_young_pause_young_only()`? Just to match the method. Feel free to ignore.
I think adding the `assert_is_young_pause` should remove the need to add `is_young_pause` prefix to these methods.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2870
More information about the hotspot-gc-dev
mailing list