RFR: 8245025: MoveAndUpdateClosure::do_addr calls function with side-effects in an assert [v2]

[Albert Mingkun Yang]

> Make the assertion code side-effect free.

Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:

  review

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2898/files
  - new: https://git.openjdk.java.net/jdk/pull/2898/files/57a6aca3..0f392b40

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2898&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2898&range=00-01

  Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2898.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2898/head:pull/2898

PR: https://git.openjdk.java.net/jdk/pull/2898