RFR: 8245025: MoveAndUpdateClosure::do_addr calls function with side-effects in an assert [v2]

[Albert Mingkun Yang]

On Mon, 15 Mar 2021 07:58:34 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review
>
> src/hotspot/share/gc/parallel/psParallelCompact.cpp line 810:
> 
>> 808:   // code, we prefer the side-effect free version so that no side-effect will
>> 809:   // not leak into release code.
>> 810:   if (use_block_table) {
> 
> I'm having trouble making sense of the last sentence of this comment, even though I think I know what is intended.  Perhaps something like "IIn debug-only code (such as asserts), we prefer the slower but side-effect free version, to avoid side effects that would not occur for release code and could potentially affect future calculations."

Fixed; I just realized that the last sentence uses double negative, but it shouldn't... Thank you for the suggestion.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2898