RFR: 8245025: MoveAndUpdateClosure::do_addr calls function with side-effects in an assert [v4]

[Albert Mingkun Yang]

> Make the assertion code side-effect free.

Albert Mingkun Yang has updated the pull request incrementally with two additional commits since the last revision:

 - review
 - Revert "review"
   
   This reverts commit de9965b3c6d06813b24469828d253c8a845b514a.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/2898/files
  - new: https://git.openjdk.java.net/jdk/pull/2898/files/de9965b3..dc4cd661

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2898&range=03
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2898&range=02-03

  Stats: 322 lines in 1 file changed: 0 ins; 0 del; 322 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2898.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2898/head:pull/2898

PR: https://git.openjdk.java.net/jdk/pull/2898