RFR: 8258431: Provide a JFR event with live set size estimate [v12]

Thomas Schatzl tschatzl at openjdk.java.net
Mon Mar 15 15:41:11 UTC 2021


On Mon, 15 Mar 2021 09:21:50 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:

>> The visibility for `_dead_space` was changed based on this comment: https://github.com/openjdk/jdk/pull/2579/files/f69541864e093bc5b250bf625ec75983764ba2bf#r585771280 by @shipilev
>
> Also, I see a bunch of methods named `get_*` in GC code alone. I have no problem renaming it to eg. `dead_space()` but it does not seem that this naming pattern is not used in hotspot.

https://wiki.openjdk.java.net/display/HotSpot/StyleGuide

> Nearly all of the guidelines mentioned below have many counter-examples in the Hotspot code base. Finding a counterexample is not sufficient justification for new code to follow the counterexample as a precedent, since readers of your code will rightfully expect your code to follow the greater bulk of precedents documented here. For more on counterexamples, see the section at the bottom of this page.
> 
>    When changing pre-existing code, it is reasonable to adjust it to match these conventions. Exception: If the pre-existing code clearly conforms locally to its own peculiar conventions, it is not worth reformatting the whole thing.

and

>  Getter accessor names are noun phrases, with no "get_" noise word. Boolean getters can also begin with "is_" or "has_".

Unless there is a good reason, please keep to few rules the official style guide for new code.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2579



More information about the hotspot-gc-dev mailing list