RFR: JDK-8263495: Gather liveness info in the mark phase of G1 full gc [v3]

Stefan Johansson sjohanss at openjdk.java.net
Tue Mar 16 14:12:33 UTC 2021


On Tue, 16 Mar 2021 01:24:58 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> src/hotspot/share/gc/g1/g1FullGCAdjustTask.cpp line 34:
>> 
>>> 32: #include "gc/g1/g1FullGCMarker.hpp"
>>> 33: #include "gc/g1/g1FullGCOopClosures.inline.hpp"
>>> 34: #include "gc/g1/g1RegionMarkStatsCache.inline.hpp"
>> 
>> This should not be needed, the cache is not accessed in this file.
>
> I thought so at the beginning, but pre-submit test report compilation error on mac and linux x86, so I added these includes.
> compilation error log is at: https://github.com/Hamlin-Li/jdk/runs/2095446669?check_suite_focus=true

It complains that `mark_object()` needs it, so it should be enough to add the include to this file: `src/hotspot/share/gc/g1/g1FullGCMarker.inline.hpp` which is where `mark_object()` is defined.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2966



More information about the hotspot-gc-dev mailing list