RFR: JDK-8263495: Gather liveness info in the mark phase of G1 full gc [v3]

Stefan Johansson sjohanss at openjdk.java.net
Tue Mar 16 14:12:32 UTC 2021


On Fri, 12 Mar 2021 14:38:20 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Gather liveness info in the mark phase of G1 full gc.
>> 
>> Per-region liveness info in the mark phase of G1 full gc is for several purposes:
>> 
>> JDK-8262068 needs it to determine whether compaction of a region should be skipped
>> JDK-8258431 for a JFR event that prints live set size estimate
>> 
>> so add this functionality.
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix compilation error

Just a few additional comments to the ones made by Thomas.

src/hotspot/share/gc/g1/g1FullGCMarker.cpp line 28:

> 26: #include "classfile/classLoaderData.hpp"
> 27: #include "gc/g1/g1FullGCMarker.inline.hpp"
> 28: #include "gc/g1/g1RegionMarkStatsCache.inline.hpp"

Shouldn't need the `inline.hpp` here, `.hpp` should be enough.

-------------

Changes requested by sjohanss (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2966



More information about the hotspot-gc-dev mailing list