RFR: JDK-8263495: Gather liveness info in the mark phase of G1 full gc [v5]

[Stefan Johansson]

On Tue, 16 Mar 2021 14:54:21 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Gather liveness info in the mark phase of G1 full gc.
>> 
>> Per-region liveness info in the mark phase of G1 full gc is for several purposes:
>> 
>> JDK-8262068 needs it to determine whether compaction of a region should be skipped
>> JDK-8258431 for a JFR event that prints live set size estimate
>> 
>> so add this functionality.
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   refine inline includes.

Starting to look good, just a few more cleanups.

src/hotspot/share/gc/g1/g1FullGCMarkTask.cpp line 33:

> 31: #include "gc/g1/g1FullGCOopClosures.inline.hpp"
> 32: #include "gc/g1/g1FullGCReferenceProcessorExecutor.hpp"
> 33: #include "gc/g1/g1RegionMarkStatsCache.inline.hpp"

Not needed afaict.

src/hotspot/share/gc/g1/g1FullGCMarker.hpp line 108:

> 106:   void flush_mark_region_cache() {
> 107:     _mark_region_cache.evict_all();
> 108:   }

Please move this definition to the cpp-file.

src/hotspot/share/gc/g1/g1FullGCMarker.hpp line 67:

> 65: 
> 66: 
> 67:   G1RegionMarkStatsCache _mark_region_cache;

Please add the include to this file: 
#include "gc/g1/g1RegionMarkStatsCache.hpp"

-------------

PR: https://git.openjdk.java.net/jdk/pull/2966