RFR: JDK-8263495: Gather liveness info in the mark phase of G1 full gc [v6]

Stefan Johansson sjohanss at openjdk.java.net
Wed Mar 17 12:42:48 UTC 2021


On Wed, 17 Mar 2021 10:02:31 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refine includes.
>
> Some additional sweep through the code showed some more minor issues. Sorry for not noticing earlier.

Testing showed that the regression I reported in the other PR is still present for this fix. Same small reproducer can be used: 
public class SystemGCLarge {
  public static Object[] holder;
  public static void main(String args[]) {
    holder = new Object[128 * 1024 *1024];
    System.gc();
    System.out.println("Done");
  }
}
 

I've made a change that eliminates the regression by making sure the cache update is not inlined and by doing so allows for other inlining to be done:
https://github.com/kstefanj/jdk/commit/abf54fbbec5aa0b2fa36c2759e0974cb21d6cf78

-------------

PR: https://git.openjdk.java.net/jdk/pull/2966



More information about the hotspot-gc-dev mailing list