RFR: 8262235: Remove unnecessary logic in hugetlbfs_sanity_check() [v2]
Stefan Johansson
sjohanss at openjdk.java.net
Tue Mar 23 10:35:59 UTC 2021
> Please review this change that removes some additional verification not really needed when doing the sanity check for hugetlbfs-pages.
>
> **Summary**
> The call to `mmap` in `hugetlbfs_sanity_check()` will only succeed if it can satisfy the mapping using large pages. If this was not the case, we would have to double check all large page mappings not just this sanity check. So the reading of `/proc/self/maps` is safe to remove.
>
> **Testing**
> Sanity run through mach 5 and local testing with and without large pages configured.
Stefan Johansson has updated the pull request incrementally with two additional commits since the last revision:
- Self review
- Ivan review
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/3048/files
- new: https://git.openjdk.java.net/jdk/pull/3048/files/2ef2316c..21e49947
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3048&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3048&range=00-01
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
Patch: https://git.openjdk.java.net/jdk/pull/3048.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/3048/head:pull/3048
PR: https://git.openjdk.java.net/jdk/pull/3048
More information about the hotspot-gc-dev
mailing list