RFR: 8231672: Simplify the reference processing parallelization framework [v4]
Kim Barrett
kbarrett at openjdk.java.net
Thu Mar 25 08:03:42 UTC 2021
On Tue, 23 Mar 2021 13:50:22 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:
>> src/hotspot/share/gc/shared/referenceProcessor.cpp line 583:
>>
>>> 581:
>>> 582: virtual void work(uint worker_id) {
>>> 583: ResourceMark rm;
>>
>> There are a number of places like here where a ResourceMark has been introduced. I've not been able to figure out what these are for. And that makes me wonder whether they are in the right place.
>
> The `ResourceMark`s was used in _some_ of the previous nested closures. See removal of `G1STWRefProcTaskProxy` and `G1CMRefProcTaskProxy`.
Yes, and I'm not sure why any of them exist, other than some paranoia that there might be some not properly scoped resource allocations somewhere inside that we want to squash on the way out of the thread. That is, these seem like just hiding potential bugs. But you probably don't want to chase down any actual bugs of that sort as part of this change, so okay, leave them.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2782
More information about the hotspot-gc-dev
mailing list