RFR: 8264027: Refactor "CLEANUP" region printing
Thomas Schatzl
tschatzl at openjdk.java.net
Mon Mar 29 13:55:46 UTC 2021
Hi all,
can I have reviews for this small cleanup that refactors "CLEANUP" region status printing?
- where managing a `FreeRegionList` is not necessary, inline the call to the method (which is guarded by a check that if logging is not enabled, we do not print anything anyway)
- for the single remaining case, create a helper method in `G1HRPrinter`
The first item has been done as per the suggestion from @kstefanj [here](https://github.com/openjdk/jdk/pull/3154#pullrequestreview-619061961) ; the alternative would be to keep the free region lists and call `G1HRPrinter::cleanup` on it later, which I actually initially implemented. I could not find a difference performance-wise.
Testing: checked if there is some perf difference on a heap with 50k regions; tier1-3
-------------
Commit messages:
- Initial implementation, move cleanup printing to closures
Changes: https://git.openjdk.java.net/jdk/pull/3243/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3243&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8264027
Stats: 71 lines in 4 files changed: 44 ins; 21 del; 6 mod
Patch: https://git.openjdk.java.net/jdk/pull/3243.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/3243/head:pull/3243
PR: https://git.openjdk.java.net/jdk/pull/3243
More information about the hotspot-gc-dev
mailing list