RFR: 8265984: Concurrent GC: Some tests fail "assert(is_frame_safe(f)) failed: Frame must be safe"

[Zhengyu Gu]

On Mon, 3 May 2021 07:25:26 GMT, Per Liden <pliden at openjdk.org> wrote:

>> src/hotspot/share/opto/runtime.cpp line 1380:
>> 
>>> 1378: 
>>> 1379:   if (nm != NULL) {
>>> 1380:     RegisterMap map(current, false);
>> 
>> Should you add `MACOS_AARCH64_ONLY(ThreadWXEnable wx(WXWrite, current));` here, as you suggested in CR?
>> Seems the code change is inconsistent with the comments above.
>
> I reverted back to exactly what we used to do here prior to JDK-8265702, to avoid affecting anything but ZGC. I'm placing the ThreadWXEnable in the ZGC nmethod barrier since we want these as close to the patching code as possible, and we can end up in there through multiple paths.

I see. Thanks.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3814