RFR: 8214237: Join parallel phases post evacuation [v4]

Thomas Schatzl tschatzl at openjdk.java.net
Fri May 7 07:28:53 UTC 2021


On Thu, 6 May 2021 11:30:01 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   iwalulya: more renaming
>
> src/hotspot/share/gc/g1/g1CollectedHeap.cpp line 3852:
> 
>> 3850:   _allocator->release_gc_alloc_regions(evacuation_info);
>> 3851: 
>> 3852:   post_evacuate_cleanup_1(per_thread_states, rdcqs);
> 
> Would it make sense to include a short comment about what these two cleanup steps do?

I fear that is going to be stale fairly quickly - the batchedgangtasks already contain a description of all tasks run within them, repeating that here seems just a way of waiting for it to get stale. I can't find a useful generic description either, so I'll leave it as is for now.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3811



More information about the hotspot-gc-dev mailing list